IXix wrote:
Is that original PXP, Chahur's mod or both?
original pxp, didn't try pxp mod.
EDIT: if the original had this bug, i assume pxp mod does too if its not something that got fixed.
its worth mentioning that both buzz notes / parameter changes and midi notes / midi control changes are affected.
i had a quick look at the PXP source code but didn't spot it immediately, but the DoMidiPlayback() code seems a little more explicite in how it handles the range etc, so worth looking at.. maybe here:
auto range = GetRowSubtickRange((*i).second.rowInBeat, (*i).second.RPB, stpt);
int dtime = range.first + min((*i).second.delaytime * (range.second - range.first) / 96, stpt - 1);
int ctime = (*i).second.cuttime < 96 ? range.first + min((*i).second.cuttime * (range.second - range.first) / 96, stpt - 1) : 0x7fffffff;
we're also investigating another bug which seems to affect recording at TPB other than 4.
that one might be related to this line: outpwi.BuzzTickPosition = (pos - (int)pos) * 4.0f / pmi->playingPatterns.begin()->second->ppat->rowsPerBeat;
this seems related to quantization of recorded events, but if that 4.0f is TPB, why is it hardcoded to 4.0f?