Page 1 of 1

PatternXP bug

Posted: Wed Feb 08, 2012 12:41 am
by bigyo
add/delete track does not work for all patterns, only for current one

Re: PatternXP bug

Posted: Wed Feb 08, 2012 5:44 am
by mes
I assumed that was intentional...I actually prefer it that way, but it would be nice to have an option for both.

Re: PatternXP bug

Posted: Wed Feb 08, 2012 12:01 pm
by bigyo
even if that was intentional there is still a bug

try this:
add a machine e.g. Jeskola Noise Generator
go to PatternXP and add a track so now it has 2 tracks
create new pattern, now both patterns have 2 tracks
delete last track in this new pattern,
now the second track from first pattern doesn't work

Re: PatternXP bug

Posted: Wed Feb 08, 2012 3:47 pm
by mes
you're right, that definitely seems like a bug. :o

Re: PatternXP bug

Posted: Wed Feb 08, 2012 4:20 pm
by UNZ
as far as i know it was always this way

the alternative would suck too: maybe you do not want buzz to delete stuff from all your patterns...see ?

Re: PatternXP bug

Posted: Wed Feb 08, 2012 4:36 pm
by snowglobe
Confirmed that deleting track 2 of pattern B disables track 2 of pattern A.
Seems undesirable.

Re: PatternXP bug

Posted: Wed Feb 08, 2012 5:30 pm
by UNZ
snowglobe wrote:Confirmed that deleting track 2 of pattern B disables track 2 of pattern A.
Seems undesirable.

and adding the track again re-enables it. its just how it works.

btw: if it would delete the track from all patterns, it would ALSO "DISABLE" TRACK 2 but in addition you'd loose your data....

Re: PatternXP bug

Posted: Wed Feb 08, 2012 5:38 pm
by Joachip
If i delete the last track of a pattern, the other patterns in the same machine are NOT affected. Personally I think we should leave it this way. I like it. :)

Re: PatternXP bug

Posted: Wed Feb 08, 2012 6:44 pm
by bigyo
the old build-in pattern editor don't work this way. number of tracks is the same for all patterns, and i like it this way :-)

there is also a bug with the new add/delete track in parameter window.

try this:
add jeskola noise generator, save song, and load it again
now go to machine view, open parameter window and try right-click and add a track
buzz stops responding

anyone can confirm that?

Re: PatternXP bug

Posted: Wed Feb 08, 2012 6:56 pm
by UNZ
bigyo wrote:the old build-in pattern editor don't work this way.
EDIT: I still think its OK the way it is, you loose no data, i can see how its not intuitive tough. Either way is OK for me, we'll see how wpf editor does it.

bigyo wrote: try this:
add jeskola noise generator, save song, and load it again
now go to machine view, open parameter window and try right-click and add a track
buzz stops responding

anyone can confirm that?
confirmed, it doesn't crash here, but it doesn't add the track either, looks like a bug. It works when you add the machine first time, but not after save/load.

Re: PatternXP bug

Posted: Wed Feb 08, 2012 7:54 pm
by bigyo
UNZ wrote:
EDIT: I still think its OK the way it is, you loose no data, i can see how its not intuitive tough. Either way is OK for me, we'll see how wpf editor does it.
i think it shouldn't work this way

suppose you have a machine with two patterns:
pattern A with 2 tracks and pattern B with 10 tracks,
and you decide to add a track to pattern A.
now pattern A has 3 tracks and pattern B has 10 tracks - but only first 3 works.

Re: PatternXP bug

Posted: Wed Feb 08, 2012 9:24 pm
by UNZ
its just the way you think about it that has to change:

machine tracks and pattern tracks are independent.

machine has 3 tracks, of course only those 3 tracks will work in pattern view, regardless of how many it has. What counts is how many tracks the MACHINE has.

Re: PatternXP bug

Posted: Wed Feb 08, 2012 9:56 pm
by bigyo
UNZ wrote:machine tracks and pattern tracks are independent.
yes, i know. but changing number of tracks of a pattern changes also number of tracks of a machine.

wouldn't be better if machine had as many tracks as the pattern that has most tracks?

Re: PatternXP bug

Posted: Wed Feb 08, 2012 10:14 pm
by UNZ
bigyo wrote:wouldn't be better if machine had as many tracks as the pattern that has most tracks?
maybe...but it would be cumbersome to remove a track, you'd have to go to EACH pattern (imagine if you have 40 patterns..) and remove the tracks... actually i think that'd be even more confusing.
that the pattern editor changes the number of tracks on a machine is more of a byproduct of increasing the trackcount when necessary, to me...

either like it is now, or like classic builtin pattern editor was imho...


i just did a few more tests and i admit i found another confusing situation.
-Machine has 7 tracks
-Pattern 00 has 5 tracks
-Pattern 01 has 7 tracks

i did ADD TRACK on Pattern 00: machine now has 6 tracks

Re: PatternXP bug

Posted: Wed Feb 08, 2012 11:42 pm
by UNZ
UNZ wrote: i just did a few more tests and i admit i found another confusing situation.
-Machine has 7 tracks
-Pattern 00 has 5 tracks
-Pattern 01 has 7 tracks

i did ADD TRACK on Pattern 00: machine now has 6 tracks
fixed in 1449, thx oskari :)

Re: PatternXP bug

Posted: Thu Feb 09, 2012 3:43 pm
by bigyo
great! :-) and add/delete track in parameter window works properly now.